Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7691 blob sidecar subnet computation not updated #4066

Open
nflaig opened this issue Dec 20, 2024 · 2 comments · May be fixed by #4067
Open

EIP-7691 blob sidecar subnet computation not updated #4066

nflaig opened this issue Dec 20, 2024 · 2 comments · May be fixed by #4067

Comments

@nflaig
Copy link
Contributor

nflaig commented Dec 20, 2024

Looks like this was missed in #4023

The electra spec only states that MAX_BLOBS_PER_BLOCK_ELECTRA should be used instead of MAX_BLOBS_PER_BLOCK

* Uses of `MAX_BLOBS_PER_BLOCK` in existing validations are replaced with `MAX_BLOBS_PER_BLOCK_ELECTRA`.

However in the gossip validation there is a check which uses BLOB_SIDECAR_SUBNET_COUNT but we should use BLOB_SIDECAR_SUBNET_COUNT_ELECTRA here as well

- _[REJECT]_ The sidecar is for the correct subnet -- i.e. `compute_subnet_for_blob_sidecar(blob_sidecar.index) == subnet_id`.

It might be required to update compute_subnet_for_blob_sidecar (or simply extend the note in p2p-interface.md)

def compute_subnet_for_blob_sidecar(blob_index: BlobIndex) -> SubnetID:

@ppopth
Copy link
Member

ppopth commented Dec 20, 2024

How about opening a PR for that?

@nflaig
Copy link
Contributor Author

nflaig commented Dec 20, 2024

How about opening a PR for that?

Can do that, was debating if a note is sufficient on p2p-interface, but updating compute_subnet_for_blob_sidecar might be better / more explicit

@nflaig nflaig linked a pull request Dec 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants