Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race Condition in Wallet.sol #79

Open
hkopp opened this issue Aug 8, 2017 · 0 comments
Open

Race Condition in Wallet.sol #79

hkopp opened this issue Aug 8, 2017 · 0 comments

Comments

@hkopp
Copy link

hkopp commented Aug 8, 2017

Hi,
Assume we have a 2-2 multisig-wallet with owners S1 and S2. Next, S1 wants to send some tokens to the receiver R. This is written to the blockchain.
Now, the issue: S1 changes his mind and revokes the operation by calling revoke. However S2 confirms shortly after. While the miners have not yet committed the function calls to the blockchain they can be arbitrarily reordered, because that's how miners work. So the confirmation may be written to the blockchain before the revocation and the tokens will be send. This is very unexpected behavior, or even a security issue.

Unfortunately I have no idea on how to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant