Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discv5: passive topic registration #144

Open
decanus opened this issue Mar 19, 2020 · 2 comments
Open

discv5: passive topic registration #144

decanus opened this issue Mar 19, 2020 · 2 comments

Comments

@decanus
Copy link

decanus commented Mar 19, 2020

So I am currently looking at the discv5 spec, and I notice that if a node wants to advertise a specific topic it needs to REGTOPIC on that specific node. I wonder if it makes sense to advertise topics in the ENR as an array of topics that MUST then be added to the topic table for a specific node. This would allow nodes to already add their peers to the topic table for the most important topics and allow for further adding other topics using the REGTOPIC command.

@fjl
Copy link
Collaborator

fjl commented Mar 19, 2020

We decided early on that topics do not belong in ENRs. In the discv5 data model, ENRs are stored in the topic table. If we want to support some kind of pre-registration for topics without an explicit REGTOPIC, the topics would need to be sent alongside the ENR, or in PING.

@fjl fjl changed the title discv5: topic registration discv5: passive topic registration Mar 19, 2020
@decanus
Copy link
Author

decanus commented Mar 19, 2020

@fjl I think something like this would make sense to reduce the amount of requests required from a client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants