Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discv5: support multi-packet talk. #192

Open
SangameswaranRS opened this issue Dec 30, 2021 · 4 comments
Open

discv5: support multi-packet talk. #192

SangameswaranRS opened this issue Dec 30, 2021 · 4 comments

Comments

@SangameswaranRS
Copy link

I was thinking that it would be nice for the spec to support multi-packet talks like NODES or so.
It would be really useful in designing "custom protocols" over talk. (rendezvous for instance).

Regarding the implementations it should be simple too, so too much effort would not be used up in implementing this change.

Disclaimer: If this is wrong, or doesn't align with eth2 roadmap or so, please feel free to close this without any explanation

@fjl
Copy link
Collaborator

fjl commented Dec 30, 2021

Hey, it's always OK to bring up enhancements!

Please provide a bit more detail about the packet types you would like to see.

@SangameswaranRS
Copy link
Author

Pretty much the same talk packet type, I was thinking that it would be great to hand out multiple talk responses per talk request, and we'd leave the app level talk handler to decide on whether it needs to send out single or multiple response packets, Depending on the protocol identifier. Protocol may still limit the number of outgoing response packets per request (4 seems like a great number, like Nodes)

I thought that this would be a nice addition because we cannot send much data in a single talk request (1280 constraint on size)

An example scenario: For designing a rendezvous kinda node for fast bootstrapping or traffic optimal bootstrapping for light clients, it would come in handy.
Yes, we may still rely on other protocols and get the ENR's externally and dump in our node table.

@creaider
Copy link

fucking liare !
Sit @ shatt

@SangameswaranRS
Copy link
Author

fucking liare !
Sit @ shatt

what is your problem?

@fjl fjl changed the title [DiscV5] Support multi-packet talk. discv5: support multi-packet talk. Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants