use self reference rather than super #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aligns the use of seek with the use in pop_frame Additionally, inheritants can now override the behaviour of the seek call in seek_in_frame(...)
|
@the reviewer of this pr Let me know if you would like a larger ratification for the change! |
davesque
approved these changes
Jan 24, 2020
carver
approved these changes
Jan 24, 2020
|
@JoranHonig sorry it took a while to get this out. Thanks for the contribution! It's available in v2.1.1 |
fselmo
pushed a commit
to fselmo/eth-abi
that referenced
this pull request
Apr 4, 2022
(cherry picked from commit 139e545)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns the use of seek with the use in pop_frame
Additionally, inheritants can now override the behaviour of the seek call in seek_in_frame(...)
What was wrong?
The call to seek in seek_in_frame() was using super() to get a reference to the function seek().
How was it fixed?
super() -> self
Cute Animal Picture