Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for python 3.8 #145

Merged
merged 3 commits into from
Jan 7, 2022
Merged

fix for python 3.8 #145

merged 3 commits into from
Jan 7, 2022

Conversation

step21
Copy link
Contributor

@step21 step21 commented Oct 21, 2020

What was wrong?

due to difference in of constructor and positional arguments in python 3.8, hypothesis needs to be a higher versio

Issue #143

How was it fixed?

hpyothesis version bump to 4.18.2
HypothesisWorks/hypothesis#1944
Summary of approach.

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@kclowes kclowes force-pushed the patch-1 branch 2 times, most recently from cf53817 to 985e0e6 Compare January 7, 2022 22:48
Copy link
Contributor

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @step21! I'm sorry it's taken us so long to get to it!

@kclowes kclowes merged commit ec58c4d into ethereum:master Jan 7, 2022
fselmo pushed a commit to fselmo/eth-abi that referenced this pull request Apr 4, 2022
* fix for python 3.8

* Add CI for python 3.8

* Add newsfragment

Co-authored-by: kclowes <kclowes@users.noreply.github.com>
(cherry picked from commit ec58c4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants