Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add make notes command, exclude venv in MANIFEST and gitignore #172

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Add make notes command, exclude venv in MANIFEST and gitignore #172

merged 4 commits into from
Jul 13, 2022

Conversation

kclowes
Copy link
Contributor

@kclowes kclowes commented May 19, 2022 •
edited
Loading

What was wrong?

I noticed a few things when I was trying to release v2.x.

  • There was no make notes command to compile release notes
  • venv files weren't being gitignored
  • venv files had the potential to make their way into the dist

How was it fixed?

  • Added a few commands to the Makefile.
  • added venvs to .gitignore
  • added venv files to be excluded in the MANIFEST.in

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@kclowes kclowes changed the title Add make notes command, exclude venv in MANIFEST and gitignore [WIP] Add make notes command, exclude venv in MANIFEST and gitignore May 19, 2022
@kclowes kclowes changed the title [WIP] Add make notes command, exclude venv in MANIFEST and gitignore Add make notes command, exclude venv in MANIFEST and gitignore May 19, 2022
@kclowes kclowes force-pushed the release-cleanups branch 2 times, most recently from b6e75d2 to 625d2ef Compare May 19, 2022 21:29
@kclowes kclowes requested review from fselmo, wolovim and pacrob May 19, 2022 21:33
pacrob
pacrob approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for delay, lgtm!

fselmo
fselmo reviewed Jun 24, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
fselmo
fselmo approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit / question on the tox env command change. Also we talked about updating the Makefile to match the template project repo since this it has been updated in the time this PR was open (sorry this took a while!).

lgtm though 👍

@kclowes kclowes force-pushed the release-cleanups branch from 115df93 to 03dd58d Compare July 13, 2022 19:09
@kclowes kclowes merged commit d467537 into ethereum:stable/2.x Jul 13, 2022
@kclowes kclowes deleted the release-cleanups branch July 13, 2022 19:32
@kclowes kclowes mentioned this pull request Jul 14, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

@fselmo fselmo fselmo approved these changes

@wolovim wolovim Awaiting requested review from wolovim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kclowes @fselmo @pacrob