Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade template #273

Merged
merged 189 commits into from
Oct 27, 2023
Merged

Upgrade template #273

merged 189 commits into from
Oct 27, 2023

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Oct 26, 2023 •
edited
Loading

What was wrong?

Lots of updates from the python project template, notably:

  • drop python 3.7 support
  • add python 3.11 support
  • using pre-commit to manage linting

How was it fixed?

Merged template

  • mypy was added to linting, but set to exclude all files. This puts it in place for when we start adding typing.
  • Since linting moved from a tox call to using pre-commit directly, try dropping [common-lint] section from tox.ini - if successful:
    • - drop in template.

To-Do:

Cute Animal Picture

image

@carver
init
a7955a5
@carver
Replace all template vars
3d87ff7
@carver
skip replacing variables inside .git/* files
cdba56a
@carver
create empty module with supplied name
9cdfd64
@carver
shorten extra name for documentation install
4a8b7b0
@carver
start at devnum 0 so the first bump goes to 1
ca670f4
@carver
add docs index
1d4e19d
@carver
add github templates for issues and pull requests
3290919
@carver
Link to dev tactical manual
2938497
@carver
add make lint-roll to locally auto de-lint
76bfefa
@carver
docs cleanup: Makefile, conf, warnings
195249c
@carver
requirements.txt: best way to build on readthedocs
109a086
@carver
bugfix: run tox -elint *after* isort
96a3717 
otherwise tox fails, and the auto-lint never runs
@carver
when do you not want ipython in local dev? never
0e57d8e
@carver
pytest default settings, plus pytest-watch
9a7d72a
@carver
add circle ci config
cb71fb4
@carver
fixups: rm template filler, xfail strict, make bug
f7b0f07
@carver
add badges: pypi version and pythons supported
4bb4f72
@carver
docs: show badge, link to release notes
b825c36
@carver
add pypy3 as a supported environment, by default
7bfa2ac
@carver
add module import test
6abf066
@carver
bugfix: setuptools reference to pypy
1695a3b
@carver
silence flake8 error during module import test
beb1b10
@carver
add doctest by default
a9d9fec
@carver
every tox environment should have a basic python
a1ba89e
@carver
squash warning about using make inside tox
37d978c
@carver
can't override python that way in tox
ecb3731
@carver
add doctest run to travis
60b026e
@carver
add doctest run to circle-ci
5890203
@carver
tox.ini bugfix: whitelist make
b3461e9
@pacrob pacrob force-pushed the upgrade-template branch 9 times, most recently from 4386955 to 9598bd9 Compare October 27, 2023 18:03
@pacrob pacrob mentioned this pull request Oct 27, 2023
Merged
@pacrob pacrob requested review from fselmo and reedsa October 27, 2023 18:21
@pacrob pacrob force-pushed the upgrade-template branch 4 times, most recently from faf86a7 to 12c43d7 Compare October 27, 2023 21:22
@pacrob pacrob merged commit 76e2bb4 into ethereum:master Oct 27, 2023
19 checks passed
@pacrob pacrob deleted the upgrade-template branch October 27, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

@reedsa reedsa Awaiting requested review from reedsa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.