Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools-markdown dependency unnecessary #124

Closed
jluttine opened this issue Aug 26, 2018 · 3 comments
Closed

setuptools-markdown dependency unnecessary #124

jluttine opened this issue Aug 26, 2018 · 3 comments

Comments

@jluttine
Copy link

PyPI supports Markdown formatted README files nowadays: https://packaging.python.org/guides/making-a-pypi-friendly-readme/

Thus, the dependency on setuptools-markdown can be removed. Also from the other eth-* packages.

@jluttine
Copy link
Author

Hmm.. I may be wrong, actually. Perhaps the long_description field is required whenever packaging, so it's not PyPI related. Anyway, just for your information.

@carver
Copy link
Collaborator

carver commented Sep 3, 2018

Hm, I'm not sure we've tried this line from the linked docs:

    long_description_content_type='text/markdown'

I'd be happy to get rid of the dependency, but also... it's working and not at the top of my list to test out this change. If someone feels like testing with a dummy pypi deployment to confirm that the content-type change would work, I'm happy to 👍 a PR making the change.

@carver
Copy link
Collaborator

carver commented Jan 21, 2021

This change is implemented in #207

@carver carver closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants