Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal replacement of active/crystallized state with single state #122

Merged
merged 7 commits into from
Nov 15, 2018

Conversation

vbuterin
Copy link
Contributor

@vbuterin vbuterin commented Nov 8, 2018

Depends on #120.

Does not include deeper simplifications that become possible with this approach; this is a fairly simple search and replace.

@prestonvanloon
Copy link
Contributor

Context? Why make this change?

@vbuterin
Copy link
Contributor Author

vbuterin commented Nov 8, 2018

It's a protocol simplification (two states down to one) that makes way for other protocol simplifications (adjusting RANDAO instantly instead of at the end of the cycle, among other things), which was not viable before because of re-hashing costs, but is viable now, because of the SSZ tree hashing proposal: #120

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass looks good. A few small notes.

I can handle the merge conflict once we merge in #120

specs/beacon-chain.md Outdated Show resolved Hide resolved
specs/beacon-chain.md Outdated Show resolved Hide resolved
specs/beacon-chain.md Outdated Show resolved Hide resolved
specs/beacon-chain.md Outdated Show resolved Hide resolved
specs/beacon-chain.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants