Add explicit assert to get_permutated_index #634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add an explicit assertion that the list size is within the bounds of the shuffler.
Why
There is an implicit assert in
int_to_bytes4
but I don't think it' immediately obvious.To find it you would need to be thinking about how Python handles
x.to_bytes(len, ..)
whenx >= 2**(len * 8)
.Also, it illustrates the bounds of the algorithm.
Additional Info
You could
assert SHUFFLE_ROUND_COUNT < 2**8
forint_to_bytes1
but it's a constant so I omitted that.