-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ethash should build with MSVC #114
base: master
Are you sure you want to change the base?
Conversation
32ab4a5
to
e25aebf
Compare
directives related to runtime & C99 header inclusion should use __GNU__, to make compiling with GNU compilers on Windows possible.
e25aebf
to
cf1ecd2
Compare
What kind of warning? |
BTW, I will be starting adding Python bindings to https://github.com/chfast/ethash. |
@chfast Regarding the build warnings, it's worth noting that MSVC at Your |
This patch allows ethash to build with MSVC under Windows.
I have built & installed the python package derived from this repository (pyethash) under Windows 10 and Fedora Linux without issue.
MSVC's /Wall does generate a number of informational compiler warnings, none of which appear new or appear serious.