Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethash should build with MSVC #114

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zv
Copy link

@zv zv commented Feb 7, 2019

This patch allows ethash to build with MSVC under Windows.

I have built & installed the python package derived from this repository (pyethash) under Windows 10 and Fedora Linux without issue.

MSVC's /Wall does generate a number of informational compiler warnings, none of which appear new or appear serious.

@zv zv changed the title Allow ethash to build under windows with setuptools Allow ethash to build with MSVC Feb 7, 2019
@zv zv changed the title Allow ethash to build with MSVC ethash should build with MSVC Feb 7, 2019
directives related to runtime & C99 header inclusion should use __GNU__, to make
compiling with GNU compilers on Windows possible.
@zv
Copy link
Author

zv commented Feb 13, 2019

@chfast @karalabe - This library is still used by a variety of Python projects. Is there a current maintainer I can reach out to about getting something like this included?

@chfast
Copy link
Member

chfast commented Feb 13, 2019

What kind of warning?

@chfast
Copy link
Member

chfast commented Feb 13, 2019

BTW, I will be starting adding Python bindings to https://github.com/chfast/ethash.

@zv
Copy link
Author

zv commented Feb 13, 2019

@chfast Regarding the build warnings, it's worth noting that MSVC at /Wall enables a wider variety of informational warnings than GCC's corresponding -Wall. In any case, here is the result of a verbose (pip -v) installation of pyethash under Windows 10

Your ethash implementation is looking great and many will gladly use your new implementation. However, it won't address the outstanding issue that many would like clean dependency fetching from pypi which is going to entail either updates to the pypi project or an effort to convince python packages which depend upon pyethash to switch to an API-compatible fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants