Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gatsby emotion plugin #10562

Closed
Tracked by #6374
pettinarip opened this issue Jun 27, 2023 · 4 comments
Closed
Tracked by #6374

remove gatsby emotion plugin #10562

pettinarip opened this issue Jun 27, 2023 · 4 comments

Comments

@pettinarip
Copy link
Member

pettinarip commented Jun 27, 2023

After we finish the UI migration of all the components and pages, remove this plugin that is not needed anymore.

@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jun 27, 2023
@pettinarip pettinarip self-assigned this Jun 27, 2023
@pettinarip pettinarip added archived: chakra-migration and removed needs triage 📥 This issue needs triaged before being worked on labels Jun 27, 2023
@TylerAPfledderer
Copy link
Contributor

@pettinarip what's left at this point?

@pettinarip
Copy link
Member Author

@TylerAPfledderer for the UI migration, just this and cleaning up some stuff like not using the SharedStyledComponents anymore, double check that we are not using styled anymore, removing deprecated components like Icon and OldEmoji. I'll do that today and close this epic.

The only component left to migrate is the react-select component that you already covered in this PR #10542. But that one is also doing the DS implementation. I'll try to get that one merged soon but I'll not consider it as necessary to close this epic.

After that, we could make tons of refactors but we will not include them in the scope of this epic. We can do them more organically as we implement the new components from the DS.

@corwintines
Copy link
Member

@pettinarip I merged the above PR, I think this can be closed out now, but wanted to double check first.

@pettinarip
Copy link
Member Author

Awesome, yes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants