Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Fix marker in the developer docs sidebar of the current active page #10813

Closed
2 tasks
0x0OZ opened this issue Jul 28, 2023 · 6 comments · Fixed by #13331
Closed
2 tasks

Bug report: Fix marker in the developer docs sidebar of the current active page #10813

0x0OZ opened this issue Jul 28, 2023 · 6 comments · Fixed by #13331
Assignees
Labels
bug 🐛 Something isn't working help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@0x0OZ
Copy link
Contributor

0x0OZ commented Jul 28, 2023

Is your feature request related to a problem? Please describe.

I am not sure 100% if this was a thing in the past but has been removed later from the website design.

Describe the solution you'd like

The link of the active page is marked with a different color in the sidebar than other links like when it's being hovered for example, this would give users a better experience for end-users when scrolling through the docs.

expected behavior, something like this:
image

Describe alternatives you've considered

ignore it, users can find out where they are when they look closely.

Additional context

.

Would you like to work on this issue?

  • Yes
  • No
@0x0OZ 0x0OZ added the feature ✨ This is enhancing something existing or creating something new label Jul 28, 2023
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jul 28, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Sep 12, 2023
@wackerow
Copy link
Member

I don't believe this is an issue anymore; please re-open if I'm misunderstanding!

@0x0OZ
Copy link
Contributor Author

0x0OZ commented Jun 14, 2024

I don't believe this is an issue anymore; please re-open if I'm misunderstanding!

I think I now understand what's wrong, it is working but there is a small issue
https://ethereum.org/en/developers/docs/smart-contracts/security/#smart-contract-auditing-services

If you open this URL you will not see the current page marked because you opened a title in it, if you click any of the titles from the page itself it will be marked with no issues
https://ethereum.org/en/developers/docs/smart-contracts/security/

I can't reopen the issue here though @wackerow

@wackerow wackerow reopened this Jun 14, 2024
@wackerow wackerow added bug 🐛 Something isn't working help wanted Extra attention is needed or someone is needed to help and removed feature ✨ This is enhancing something existing or creating something new Status: Stale This issue is stale because it has been open 30 days with no activity. needs triage 📥 This issue needs triaged before being worked on labels Jun 14, 2024
@0x0OZ 0x0OZ changed the title Feature request: add marker in the developer docs sidebar of the current active page Bug report: Fix marker in the developer docs sidebar of the current active page Jun 15, 2024
@corwintines
Copy link
Member

Anything you need a hand with here @0x0OZ?

@0x0OZ
Copy link
Contributor Author

0x0OZ commented Jul 5, 2024

Anything you need a hand with here @0x0OZ?

Yes please, just a small thing I have explained it in the PR.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 5, 2024
This was referenced Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants