Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart text without overlapping #12099

Closed
1 of 2 tasks
Satglow opened this issue Feb 2, 2024 · 14 comments · Fixed by #13779
Closed
1 of 2 tasks

Chart text without overlapping #12099

Satglow opened this issue Feb 2, 2024 · 14 comments · Fixed by #13779
Labels
design required 🎨 This involves design changes feature ✨ This is enhancing something existing or creating something new question ❓ Further information is requested

Comments

@Satglow
Copy link

Satglow commented Feb 2, 2024

Is your feature request related to a problem? Please describe.

Annual Energy Consumption chart – the translated text is overlapping each other. Shall the long expressions put in a hyphenated way (as a translation), following the column width somehow? Or a language-based automatic hyphenation can be applied for these strings?

https://ethereum.org/hu/what-is-ethereum

Annual energy cons chart - text

Describe the solution you'd like

Readable text below the chart.

Describe alternatives you've considered

None

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@Satglow Satglow added the feature ✨ This is enhancing something existing or creating something new label Feb 2, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Feb 2, 2024
@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented Feb 6, 2024

@nloureiro @pettinarip should we have a storybook up to provide isolated visual testing of these charts?

Not seeing a clean solution without the chart being it's own block beneath the content at a higher breakpoint. 🤔

@nloureiro
Copy link
Contributor

@nloureiro @pettinarip should we have a storybook up to provide isolated visual testing of these charts?

Not seeing a clean solution without the chart being it's own block beneath the content at a higher breakpoint. 🤔

this is a kinda unique chart, not a component that will be reused, I think, right?

if yes, it might not need to be in the storybook. dunno, what do you think?

@pettinarip
Copy link
Member

Thanks to @Satglow for reporting this bug!

@nloureiro not sure what should be the best approach here, automatic hyphenation might be an easy workaround, but not the ideal as it makes it hard to read. Another idea: we could reduce the number of columns shown for certain locales.

======

@TylerAPfledderer SB related, yeah, not sure if a story for this component is worth it (this could be covered in the page stories if we have them at some point xD), but wouldn't hurt if you still want to do it. Anyway, do you know if Chromatic has snapshots per locale? I think it will always only take one snapshot per component unless we somehow specify that we want to use a different locale (???). Or are you thinking of some other way to test this?

@TylerAPfledderer
Copy link
Contributor

Thanks to @Satglow for reporting this bug!

@nloureiro not sure what should be the best approach here, automatic hyphenation might be an easy workaround, but not the ideal as it makes it hard to read. Another idea: we could reduce the number of columns shown for certain locales.

======

@TylerAPfledderer SB related, yeah, not sure if a story for this component is worth it (this could be covered in the page stories if we have them at some point xD), but wouldn't hurt if you still want to do it. Anyway, do you know if Chromatic has snapshots per locale? I think it will always only take one snapshot per component unless we somehow specify that we want to use a different locale (???). Or are you thinking of some other way to test this?

I didn't have anything in particular. But for a snapshot per locale, can consider Chromatic modes: https://www.chromatic.com/docs/modes/

I can at the very least look at applying this globally.

Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Mar 24, 2024
@WebSculptor
Copy link

Hi I would love to work on this

@TylerAPfledderer
Copy link
Contributor

Hey, @WebSculptor !

What do you have in mind for solving this?

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Apr 29, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 30, 2024
@nloureiro
Copy link
Contributor

@pettinarip @nhsz is this solved by the new graph framework?

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 31, 2024
@wackerow wackerow added dev required This requires developer resources and removed needs triage 📥 This issue needs triaged before being worked on labels Jun 14, 2024
@wackerow wackerow added the question ❓ Further information is requested label Jun 14, 2024
@corwintines
Copy link
Member

Adding this to dev sync to clear up

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 26, 2024
@minimalsm
Copy link
Contributor

@corwintines did we get an answer here?

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 21, 2024
@wackerow wackerow added design required 🎨 This involves design changes and removed dev required This requires developer resources labels Sep 2, 2024
@wackerow
Copy link
Member

wackerow commented Sep 2, 2024

Opening this back up... @nloureiro If you have any thoughts on design considerations here. @nhsz Have unassigned you so we can open this back up for the community.

@corwintines
Copy link
Member

@nloureiro I posted a PR here to rotate the label by 45 degrees. If you approve this, we can bring it in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design required 🎨 This involves design changes feature ✨ This is enhancing something existing or creating something new question ❓ Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants