Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Wallet bug: accordion index stays open when switching filters #14446

Open
1 of 2 tasks
wackerow opened this issue Dec 2, 2024 · 1 comment
Open
1 of 2 tasks

Find Wallet bug: accordion index stays open when switching filters #14446

wackerow opened this issue Dec 2, 2024 · 1 comment
Labels
bug 🐛 Something isn't working

Comments

@wackerow
Copy link
Member

wackerow commented Dec 2, 2024

Describe the bug

When switching filters or personas on the find wallets page, the open accordions persist at a specific index position instead of the open/close state being attached to a specific wallet listing.

In screen recording below, see the seconds wallet position stays open, even if the filters change which wallet is in that position.

To reproduce

  1. Go to https://ethereum.org/en/wallets/find-wallet/
  2. Toggle open a position and then change filters.. find a case where the wallet changes but the accordion stays open

Expected behavior

The open/close state should stay with a specific wallet when filters change, not to the position in the list.

Screenshots

Screen.Recording.2024-12-02.at.12.15.23.mov

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@wackerow wackerow added the bug 🐛 Something isn't working label Dec 2, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Dec 2, 2024
@isabelladebrito isabelladebrito removed the needs triage 📥 This issue needs triaged before being worked on label Dec 3, 2024
@dbarabashh
Copy link
Contributor

sorry for taking on this task without any prior notice. i decided to create a pull request really quickly, so i'm ready to continue the discussion in the pull request if anything needs to be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants