Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect totalDifficulty after FastSync in skipHistory mode #1041

Closed
mkalinin opened this issue Mar 26, 2018 · 1 comment
Closed

Incorrect totalDifficulty after FastSync in skipHistory mode #1041

mkalinin opened this issue Mar 26, 2018 · 1 comment
Labels
bug

Comments

@mkalinin
Copy link
Contributor

If sync.fast.skipHistory = true then block bodies fetching is omitted and the code which adjusts total difficulty is never invoked. totalDifficulty must be calculated independently, probably during syncSecure stage.
@mkalinin mkalinin added the bug label Mar 26, 2018
@mkalinin mkalinin mentioned this issue Mar 26, 2018
Closed
@zilm13 zilm13 mentioned this issue Apr 25, 2018
Merged
@zilm13
Copy link
Collaborator

zilm13 commented May 4, 2018

@mkalinin Could be closed

@mkalinin mkalinin closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkalinin @zilm13