Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature so that VM can request inserting code into the state #53

Open
axic opened this issue Aug 9, 2018 · 3 comments
Open

Add feature so that VM can request inserting code into the state #53

axic opened this issue Aug 9, 2018 · 3 comments

Comments

@axic
Copy link
Member

axic commented Aug 9, 2018

For example Hera could request to insert precompiles at certain addresses.

I would imagine this could work as adding a function create_account(address, code, balance) which can be called within execute. We trust the VM to do anything already, so this shouldn't raise any permission questions.

@chfast
Copy link
Member

chfast commented Aug 9, 2018

I don't mind to have it in EVMC, but there might not be so easy to implement it on Client side because they usually does not expose API for it directly.

@axic
Copy link
Member Author

axic commented Aug 9, 2018

I was thinking about this and of course it has to be optional, but instead of in execute, I think it should be in some kind of initialisation stage. Actually that makes sense with #44. I am not fully sure about it, probably better to skip this for ABIv5.

@chfast
Copy link
Member

chfast commented Aug 9, 2018

I will definitely include this in the design of 2-phase initialization.

I'd like to put this in a "experimental" namespace to indicate this is not a stable API and implementation is not mandatory. Then we could include this as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants