Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assembled spec should not be dereferenced #70

Closed
shanejonas opened this issue Sep 13, 2021 · 1 comment · Fixed by #156
Closed

assembled spec should not be dereferenced #70

shanejonas opened this issue Sep 13, 2021 · 1 comment · Fixed by #156
Labels
A-tool Area: tooling C-enhance Category: a request for an improvement E-medium Experience: of moderate difficulty

Comments

@shanejonas
Copy link
Contributor

shanejonas commented Sep 13, 2021

dereferenced documents should only really live in memory since they can get quite large in json and have circular references. The tools that use openrpc are required to dereference documents before operating on them.

this is also making it harder to compose the output in other projects like https://github.com/MetaMask/api-specs/

let spec = await dereferenceDocument({

@lightclient
Copy link
Member

lightclient commented Sep 14, 2021

@shanejonas how should we handle situations where we want to merge several allOf combinations? It seems like then we'll have to create some new schemas on the fly and determine which schemas are never used independent of another schema.

@lightclient lightclient added A-tool Area: tooling C-enhance Category: a request for an improvement E-medium Experience: of moderate difficulty labels Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tool Area: tooling C-enhance Category: a request for an improvement E-medium Experience: of moderate difficulty
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants