Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fill): errors trying to fill prague with eels #954

Closed
danceratopz opened this issue Nov 18, 2024 · 2 comments
Closed

fix(fill): errors trying to fill prague with eels #954

danceratopz opened this issue Nov 18, 2024 · 2 comments
Assignees
Labels
scope:fill Scope: fill command type:bug Something isn't working

Comments

@danceratopz
Copy link
Member

Looks like the branch has moved:

git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git clone -v --single-branch --branch=prague -- https://github.com/ethereum/execution-specs.git /home/dtopz/.cache/ethereum-spec-evm-resolver/Prague
  stderr: 'Cloning into '/home/dtopz/.cache/ethereum-spec-evm-resolver/Prague'...
POST git-upload-pack (364 bytes)
warning: Could not find remote branch prague to clone.
fatal: Remote branch prague not found in upstream origin
'
@danceratopz danceratopz added type:bug Something isn't working scope:fill Scope: fill command labels Nov 18, 2024
@danceratopz danceratopz self-assigned this Nov 18, 2024
@danceratopz
Copy link
Member Author

Update: Changing the branch locally from prague to forks/prague and bumping to the latest commit in eels_resolutions.json:

diff --git a/eels_resolutions.json b/eels_resolutions.json
index b1d1f46f44..cfe198a67f 100644
--- a/eels_resolutions.json
+++ b/eels_resolutions.json
@@ -36,7 +36,7 @@
     },
     "Prague": {
         "git_url": "https://github.com/ethereum/execution-specs.git",
-        "branch": "prague",
-        "commit": "2875a733d6b1e9e751e437c7894d3ebe6ff58ecc"
+        "branch": "forks/prague",
+        "commit": "a95b7aa7aaa152ff5210fd3bed5921bb5c6f2f59"
     }
 }

fixes the original error message.

When running main f8e4ee9 with the above changes to the resolutions:

fill --fork=Prague tests/prague/eip2537_bls_12_381_precompiles/ -x

we now have (see stderr output):

tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g1add.py F

==================================================================== FAILURES ====================================================================
____________________________________________ test_valid[fork_Prague-blockchain_test-bls_g1add_g1+p1-] ____________________________________________
tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g1add.py:54: in test_valid
    state_test(
src/pytest_plugins/filler/filler.py:743: in __init__
    fixture = self.generate(
src/ethereum_test_specs/state.py:198: in generate
    return self.generate_blockchain_test().generate(
src/ethereum_test_specs/blockchain.py:698: in generate
    return self.make_fixture(t8n, fork, eips)
src/ethereum_test_specs/blockchain.py:542: in make_fixture
    header, txs, _, new_alloc, new_env = self.generate_block_data(
src/ethereum_test_specs/blockchain.py:474: in generate_block_data
    raise Exception(
E   Exception: Requests root in header does not match the requests root in the transition tool output: 0x6036c41849da9c076ed79654d434017387a88fb833c2856b32e18218b3341c5f != 0x18b92290dde7b61852759fc6d64a509fa7d839b337096abaa341032846745e46
-------------------------------------------------------------- Captured stderr call --------------------------------------------------------------
local - - [18/Nov/2024 11:47:49] code 501, message Unsupported method ('GET')

@danceratopz
Copy link
Member Author

This was solved by execution-specs#1040 (and #969).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fill Scope: fill command type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant