fix(specs): Ensure tracking before first access (#1722)

Author: nerolation

src/ethereum/forks/amsterdam/vm/instructions/system.py

@@ -110,6 +110,9 @@ def generic_create(
 
     evm.accessed_addresses.add(contract_address)
 
+    # Track address access for BAL
+    track_address_access(state.change_tracker, contract_address)
+
     if account_has_code_or_nonce(
         state, contract_address
     ) or account_has_storage(state, contract_address):
@@ -145,8 +148,6 @@ def generic_create(
         parent_evm=evm,
     )
 
-    track_address_access(state.change_tracker, contract_address)
-
     child_evm = process_create_message(child_message)
 
     if child_evm.error:
@@ -341,8 +342,6 @@ def generic_call(
         parent_evm=evm,
     )
 
-    track_address_access(evm.message.block_env.state.change_tracker, to)
-
     child_evm = process_message(child_message)
 
     if child_evm.error:
@@ -396,6 +395,9 @@ def call(evm: Evm) -> None:
         evm.accessed_addresses.add(to)
         access_gas_cost = GAS_COLD_ACCOUNT_ACCESS
 
+    # Track address access for BAL
+    track_address_access(evm.message.block_env.state.change_tracker, to)
+
     code_address = to
     (
         disable_precompiles,
@@ -485,6 +487,11 @@ def callcode(evm: Evm) -> None:
         evm.accessed_addresses.add(code_address)
         access_gas_cost = GAS_COLD_ACCOUNT_ACCESS
 
+    # Track address access for BAL
+    track_address_access(
+        evm.message.block_env.state.change_tracker, code_address
+    )
+
     (
         disable_precompiles,
         code_address,
@@ -503,10 +510,6 @@ def callcode(evm: Evm) -> None:
     )
     charge_gas(evm, message_call_gas.cost + extend_memory.cost)
 
-    track_address_access(
-        evm.message.block_env.state.change_tracker, code_address
-    )
-
     # OPERATION
     evm.memory += b"\x00" * extend_memory.expand_by
     sender_balance = get_account(
@@ -560,6 +563,11 @@ def selfdestruct(evm: Evm) -> None:
         evm.accessed_addresses.add(beneficiary)
         gas_cost += GAS_COLD_ACCOUNT_ACCESS
 
+    # Track address access for BAL
+    track_address_access(
+        evm.message.block_env.state.change_tracker, beneficiary
+    )
+
     if (
         not is_account_alive(evm.message.block_env.state, beneficiary)
         and get_account(
@@ -635,6 +643,11 @@ def delegatecall(evm: Evm) -> None:
         evm.accessed_addresses.add(code_address)
         access_gas_cost = GAS_COLD_ACCOUNT_ACCESS
 
+    # Track address access for BAL
+    track_address_access(
+        evm.message.block_env.state.change_tracker, code_address
+    )
+
     (
         disable_precompiles,
         code_address,
@@ -648,10 +661,6 @@ def delegatecall(evm: Evm) -> None:
     )
     charge_gas(evm, message_call_gas.cost + extend_memory.cost)
 
-    track_address_access(
-        evm.message.block_env.state.change_tracker, code_address
-    )
-
     # OPERATION
     evm.memory += b"\x00" * extend_memory.expand_by
     generic_call(
@@ -708,6 +717,9 @@ def staticcall(evm: Evm) -> None:
         evm.accessed_addresses.add(to)
         access_gas_cost = GAS_COLD_ACCOUNT_ACCESS
 
+    # Track address access for BAL
+    track_address_access(evm.message.block_env.state.change_tracker, to)
+
     code_address = to
     (
         disable_precompiles,