parse block_hashes key as hex
#1099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Thanks @gurukamath! Still failing I'm afraid, but a slightly different fail mode. You can reproduce it on https://github.com/ethereum/execution-spec-tests/tree/export_int_as_hex with:
uv run --with ethereum@git+https://github.com/gurukamath/execution-specs.git@t8n-hex-inputs pytest -c pytest-framework.ini
Relevant backtrace:
File "/home/dtopz/.cache/ethereum-spec-evm-resolver/Berlin/src/ethereum_spec_tools/evm_tools/daemon.py", line 66, in do_POST
main(args=args, out_file=out_wrapper, in_file=input)
File "/home/dtopz/.cache/ethereum-spec-evm-resolver/Berlin/src/ethereum_spec_tools/evm_tools/__init__.py", line 109, in main
return t8n_tool.run()
File "/home/dtopz/.cache/ethereum-spec-evm-resolver/Berlin/src/ethereum_spec_tools/evm_tools/t8n/__init__.py", line 461, in run
self.apply_body()
File "/home/dtopz/.cache/ethereum-spec-evm-resolver/Berlin/src/ethereum_spec_tools/evm_tools/t8n/__init__.py", line 377, in apply_body
process_transaction_return = self.fork.process_transaction(
File "/home/dtopz/.cache/ethereum-spec-evm-resolver/Berlin/src/ethereum/berlin/fork.py", line 712, in process_transaction
output = process_message_call(message, env)
File "/home/dtopz/.cache/ethereum-spec-evm-resolver/Berlin/src/ethereum/berlin/vm/interpreter.py", line 119, in process_message_call
evm = process_message(message, env)
File "/home/dtopz/.cache/ethereum-spec-evm-resolver/Berlin/src/ethereum/berlin/vm/interpreter.py", line 233, in process_message
evm = execute_code(message, env)
File "/home/dtopz/.cache/ethereum-spec-evm-resolver/Berlin/src/ethereum/berlin/vm/interpreter.py", line 296, in execute_code
op_implementation[op](evm)
File "/home/dtopz/.cache/ethereum-spec-evm-resolver/Berlin/src/ethereum/berlin/vm/instructions/block.py", line 49, in block_hash
push(evm.stack, U256.from_be_bytes(hash))
File "/home/dtopz/code/github/danceratopz/eest/.venv/lib/python3.10/site-packages/ethereum_types/numeric.py", line 561, in from_be_bytes
if len(buffer) > byte_count:
TypeError: object of type 'NoneType' has no len()
That command doesn't do what you want it to do. You need to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #1078 )
What was wrong?
The block hashes keys are sent to
t8nas a string of number but has to be a hexRelated to Issue #1078
How was it fixed?
Convert the keys from hex to int.
Cute Animal Picture