Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question] eth/backend: unused server field #20043

Closed
trung opened this issue Sep 9, 2019 · 1 comment · Fixed by #20049
Closed

[Question] eth/backend: unused server field #20043

trung opened this issue Sep 9, 2019 · 1 comment · Fixed by #20049

Comments

@trung
Copy link
Contributor

trung commented Sep 9, 2019

I noticed there's an unused field server in Ethereum struct (line 72)

go-ethereum/eth/backend.go

Lines 66 to 73 in 67bfc93

type Ethereum struct {
config *Config
// Channel for shutting down the service
shutdownChan chan bool
server *p2p.Server

Is it a place holder to be used in the future?
@karalabe
Copy link
Member

Please open a PR to remove it.

@trung trung mentioned this issue Sep 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

eth/backend: remove unused field trung/go-ethereum
2 participants
@trung @karalabe