Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoundContract Call no longer returning correct solidity error #21739

Closed
yazzaoui opened this issue Oct 22, 2020 · 0 comments · Fixed by #21743
Closed

BoundContract Call no longer returning correct solidity error #21739

yazzaoui opened this issue Oct 22, 2020 · 0 comments · Fixed by #21743
Assignees

Comments

@yazzaoui
Copy link

Hello,

#21091 has changed the behavior of the Call method in accounts/abi/bind/base.go

The correct contract error from CallContract is no longer returned, and Unpack is called even though CallContract has failed, which I think is a mistake.

And some third-party apps using abigen are relying on the old behavior, so would be great to have the correct contract error message back.

Expected behaviour

If the contract invocation has failed (due to require or else), return the correct associated error message

Actual behaviour

If the contract invocation has failed (due to require or else) "abi: attempting to unmarshall an empty string while arguments are expected" is returned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants