dumpconfig doesn't output config for metrics

[lightclient]

System information

Geth version: v1.9.25
OS & Version: linux

Expected behaviour

Print config that turns on monitoring.

Actual behaviour

No observable change to output

Steps to reproduce the behaviour

$ diff <(geth --metrics --pprof dumpconfig) <(geth dumpconfig)
$

[rjl493456442]

The metrics flags are not part of the config. Are they necessary for you in some special scenario?

[lightclient]

No, not really. As a user, I just found it confusing that they weren't part of the configuration. I was trying to generate a few config.toml files for various scenarios and seems like --metrics should be configurable by the TOML.

[MysticRyuujin]

I opened a similar issue a while back, seems to just be a continuation of that 🙂

#21262

[lightclient]

Ah I see, nice catch. Also appears that --goerli isn't dumpable.

[MysticRyuujin]

I think --goerli just modifies the network flag and maybe a couple others, the flag itself doesn't dump, but the RESULTS of the flag does get dumped.

[lightclient]

@MysticRyuujin although it updates the config with the correct network ID, it doesn't start with the correct genesis block (starts with mainnet).

[11qu1d]

Noticed this problem while trying to consolidate all config into a single file. At the moment i have to pass all the metrics config as flags and the rest in the config file. Not ideal if we want to keep things consistent.