[BUG][Clique] Database has receipts with a legacy format on fresh node, cannot restart node #25498
Comments
|
Might be related to #24724 |
|
Can you please re-compile with this patch and see if it still halts on start? @karalabe pointed out an issue in the legacy detection function: if there are no non-empty receipts in the freezer, the detection gives a false positive. Which we think might be your case. Or did you have receipts in the first 30k (or even 60k) blocks? diff --git a/cmd/geth/config.go b/cmd/geth/config.go
index 2562de8ae..519868de8 100644
--- a/cmd/geth/config.go
+++ b/cmd/geth/config.go
@@ -173,12 +173,13 @@ func makeFullNode(ctx *cli.Context) (*node.Node, ethapi.Backend) {
if cfg.Eth.NetworkId == 1 && ghash == params.MainnetGenesisHash {
firstIdx = 46147
}
- isLegacy, _, err := dbHasLegacyReceipts(eth.ChainDb(), firstIdx)
+ isLegacy, firstLegacy, err := dbHasLegacyReceipts(eth.ChainDb(), firstIdx)
if err != nil {
log.Error("Failed to check db for legacy receipts", "err", err)
} else if isLegacy {
stack.Close()
- utils.Fatalf("Database has receipts with a legacy format. Please run `geth db freezer-migrate`.")
+ log.Error("Database has receipts with a legacy format", "firstLegacy", firstLegacy)
+ utils.Fatalf("Aborting. Please run `geth db freezer-migrate`.")
}
}
// Configure GraphQL if requested
diff --git a/cmd/geth/dbcmd.go b/cmd/geth/dbcmd.go
index ab7427712..bb53a632e 100644
--- a/cmd/geth/dbcmd.go
+++ b/cmd/geth/dbcmd.go
@@ -822,11 +822,15 @@ func dbHasLegacyReceipts(db ethdb.Database, firstIdx uint64) (bool, uint64, erro
}
}
}
- // Is first non-empty receipt legacy?
first, err := db.Ancient("receipts", firstIdx)
if err != nil {
return false, 0, err
}
+ // We looped over all receipts and they were all empty
+ if bytes.Equal(first, emptyRLPList) {
+ return false, 0, nil
+ }
+ // Is first non-empty receipt legacy?
legacy, err = types.IsLegacyStoredReceipts(first)
return legacy, firstIdx, err
} |
|
Sure, I will do this later today. And yes, in first 30k blocks I dont think I have any receipts, I usually spin up private network and let it sit for few days to ensure it's set up correctly and works. |
|
Sorry for late reply. The patch seems to make node run correctly, I can include logs but there is nothing unusal after the patch. |
|
@s1na did you ever PR that patch? |
|
Since @s1na provided working patch, I wouldn't want this issue to get forgotten as fix is already known. Is there any way I could help to push this forward? |
System information
Debian 11 server (CPX21 @ hetzner)
Geth
Version: 1.10.21-stable
Git Commit: 6710942
Git Commit Date: 20220727
Architecture: amd64
Go Version: go1.18.4
Operating System: linux
Node type: Archive
Context
I set up private clique PoA chain, it works until first geth shutdown (I tested this on my archive node, not brave enough to try to shut down my sealer to check if it would die too).
The node the issue apeared on is Archive node.
Expected behaviour
After node clean shut down, the node should be able to stand back up
Actual behaviour
After node clean shutdown, upon restart node complains it's transaction receipts are in legacy format. Running suggested command does not change behaviour.
Steps to reproduce the behaviour
archivedatabaseBacktrace
Logs (complete since working node -> broken node -> attempted to use migrate command -> still broken)
`genesis.json`
{ "config": { "chainId": 31072022, "homesteadBlock": 0, "eip150Block": 0, "eip150Hash": "0x0000000000000000000000000000000000000000000000000000000000000000", "eip155Block": 0, "eip158Block": 0, "byzantiumBlock": 0, "constantinopleBlock": 0, "petersburgBlock": 0, "istanbulBlock": 0, "clique": { "period": 4, "epoch": 30000 } }, "nonce": "0x0", "timestamp": "0x62E6CD48", "extraData": "0x000000000000000000000000000000000000000000000000000000000000000001000007865ade114f9f827a8e2531d1f2debc9a0200000181cc3b13659c62216820d4bec34187c503000009a0accfcd3bb4fc273de274aedc295be70400000a697d73435a5cde5ad0a24773bcb5aea105000004f738ac3509fbbfec2a0591ef646137370000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", "gasLimit": "0x47b760", "difficulty": "0x1", "mixHash": "0x0000000000000000000000000000000000000000000000000000000000000000", "coinbase": "0x0000000000000000000000000000000000000000", "alloc": {"_comment":"for brieviety I removed alloc, it's single address + 00 to FF addresses" }, "number": "0x0", "gasUsed": "0x0", "parentHash": "0x0000000000000000000000000000000000000000000000000000000000000000", "baseFeePerGas": null }I can provide
configuration.tomlfile that I use to run geth, if requestedEdit: I found out about
--ignore-legacy-receipts(thank you for having these things in commit names / descriptions, really helpfull!) that works around the issue. Issue is still valid though, these receipts shouldn't be written to the database in the first place (entire chain was bootstrapped with geth 1.10.21)The text was updated successfully, but these errors were encountered: