Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The question about ‘EIP150Hash’ in ‘params.ChainConfig’ #26994

Closed
joohhnnn opened this issue Mar 28, 2023 · 1 comment · Fixed by #27087
Closed

The question about ‘EIP150Hash’ in ‘params.ChainConfig’ #26994

joohhnnn opened this issue Mar 28, 2023 · 1 comment · Fixed by #27087

Comments

@joohhnnn
Copy link
Contributor

Why is the EIP150Hash (the block header hash for the EIP-150 protocol upgrade) separately marked in the ChainConfig struct? After reviewing EIP-150, it seems that there were no changes made to the hash algorithm. Instead, only gas cost adjustments were made. If the EIP150Hash field is not highlighted separately, it may cause confusion or misinterpretation for those who are only interested in the changes related to hash algorithm.

@karalabe
Copy link
Member

I think the ForkXYZHash was a legacy idea where before the fork we specify the block number and after the fork we hard code the forked hash too as an extra defensive mechanism. It wasn't really used ever since forks weren't contentious and for all the various testnets and private network it was just a PITA to keep setting. Should really just drop that field altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants