Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Prometheus metrics for blobpool are not formatted correctly. #27900

Closed
imulmat4 opened this issue Aug 10, 2023 · 2 comments
Closed

New Prometheus metrics for blobpool are not formatted correctly. #27900

imulmat4 opened this issue Aug 10, 2023 · 2 comments
Labels

Comments

@imulmat4
Copy link
Contributor

System information

Geth version: 1.12.1
CL client & version: e.g. lighthouse/nimbus/prysm@v1.0.0
OS & Version: Windows/Linux/OS1.12.
Commit hash : (if develop)

Expected behaviour

Prometheus metrics are formatted in the correct format with underscores and not hyphens.

Actual behaviour

All the new blobpool metircs have a - and that breaks all the Prometheus scrapers since prometheus doesnt support hyphen metric names. Error I am getting:
Error reading metrics for "http://127.0.0.1:6000/debug/metrics/prometheus": reading text format failed: text format parsing error in line 66: invalid metric name in comment

Steps to reproduce the behaviour

Just run geth on version 1.12.1

Backtrace

[backtrace]

When submitting logs: please submit them as text and not screenshots.

@imulmat4
Copy link
Contributor Author

I opened #27901 which should fix the above, but not sure if I am missing more context

@karalabe
Copy link
Member

Thanks PR looked good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants