Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimulatedBackend doesn't match ethereum interface and ethclient #28431

Closed
s1na opened this issue Oct 28, 2023 · 1 comment · Fixed by #28202
Closed

SimulatedBackend doesn't match ethereum interface and ethclient #28431

s1na opened this issue Oct 28, 2023 · 1 comment · Fixed by #28202
Labels

Comments

@s1na
Copy link
Contributor

s1na commented Oct 28, 2023

As far as I understand the goal is that the interfaces defined here match that of ethclient and SimulatedBackend so it's easy to swap out a real node RPC server with a simulated blockchain. However there are currently a few differences preventing this:

  • PendingBalanceAt, PendingStorageAt and PendingTransactionCount are not defined on the simulated backend
  • SubscribePendingTransactions is part of the interfaces, but it is not defined on the simulated backend. Also it is defined on gethclient, not directly on ethclient.
@s1na s1na added the type:bug label Oct 28, 2023
@bnovil
Copy link
Contributor

bnovil commented Oct 30, 2023

I have the same thought. It seems better that SimulatedBackend implements the interface PendingStateReader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants