Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-ethereum/crypto prevents program from compiling successfully #30188

Closed
i-fix-retarded-bugs opened this issue Jul 18, 2024 · 5 comments
Closed
Labels
Milestone

Comments

@i-fix-retarded-bugs
Copy link

System information

Irrelevant

Expected behaviour

Program compiles

Actual behaviour

github.com/ethereum/go-ethereum@v1.14.7/crypto/signature_nocgo.go:91:14: assignment mismatch: 2 variables but btc_ecdsa.SignCompact returns 1 value

Steps to reproduce the behaviour

Use go-ethereum@v1.14.7 in your code and try to build your program.

P.S.
v.1.14.6 does not have this issue.

@i-fix-retarded-bugs
Copy link
Author

@AlexanderMint

@fjl
Copy link
Contributor

fjl commented Jul 18, 2024

This has been fixed in #30181, which is not released yet. Please downgrade your btcec dependency version to fix this issue.

@fjl fjl added this to the 1.14.8 milestone Jul 18, 2024
@AlexanderMint
Copy link
Contributor

AlexanderMint commented Jul 18, 2024

Before the new version is released, you can:

 go get github.com/btcsuite/btcd/btcec/v2@v2.3.3

@echarrod
Copy link

echarrod commented Aug 7, 2024

Hi team 👋 any idea when this fix will be included in a release?

@fjl
Copy link
Contributor

fjl commented Aug 12, 2024

Fix is released now in v1.14.8.

@fjl fjl closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants