Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields with type common.Address is not checksummed in json rpc request #30618

Closed
mmsqe opened this issue Oct 18, 2024 · 1 comment
Closed

Fields with type common.Address is not checksummed in json rpc request #30618

mmsqe opened this issue Oct 18, 2024 · 1 comment
Labels

Comments

@mmsqe
Copy link
Contributor

mmsqe commented Oct 18, 2024

System information

Geth version: geth 1.14.12-unstable
CL client & version: e.g. lighthouse/nimbus/prysm@v1.0.0
OS & Version: OSX
Commit hash : afea3bd

Expected behaviour

fields with type common.Address should be checksummed after JSON marshalling

Actual behaviour

fields with type common.Address are in lowercase

Steps to reproduce the behaviour

call eth_getBlockByNumber with height 0x14044b3

return hexutil.Bytes(a[:]).MarshalText()

Can we use a.checksumHex() here?

When submitting logs: please submit them as text and not screenshots.

@lightclient
Copy link
Member

Consumers of the RPC should decide to show checksummed addresses to users. I don't really see a purpose for this and would prefer to not implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants