cmd/hiveview: enable some more useful eslint rules

Author: fjl

cmd/hiveview/assets/.eslintrc.js

@@ -29,5 +29,23 @@ module.exports = {
         "no-unused-vars": [
             "error", { "vars": "all", "args": "none", "ignoreRestSiblings": false }
         ],
+        "no-unused-private-class-members": [
+            "error"
+        ],
+        "no-else-return": [
+            "error"
+        ],
+        "no-unreachable-loop": [
+            "error"
+        ],
+        "no-duplicate-imports": [
+            "error"
+        ],
+        "no-unmodified-loop-condition": [
+            "warn"
+        ],
+        // "no-use-before-define": [
+        //     "warn"
+        // ],
     }
 }

cmd/hiveview/assets/lib/app-suite.js

@@ -238,15 +238,15 @@ function testCaseDuration(test) {
 function scrollToTest(suiteData, testIndex) {
     let table = $('#execresults').dataTable().api();
     let row = findRowByTestIndex(table, testIndex);
-    if (row) {
-        if (row.page() != table.page()) {
-            table.page(row.page()).draw(false);
-        }
-        row.node().scrollIntoView();
-        toggleTestDetails(suiteData, table, row.node());
-    } else {
+    if (!row) {
         console.error('invalid row in scrollToTest:', testIndex);
+        return;
     }
+    if (row.page() != table.page()) {
+        table.page(row.page()).draw(false);
+    }
+    row.node().scrollIntoView();
+    toggleTestDetails(suiteData, table, row.node());
 }
 
 // findRowByTestIndex finds the dataTables row corresponding to a testIndex.
@@ -383,9 +383,8 @@ function countLines(text) {
         offset = text.indexOf('\n', offset);
         if (offset == -1) {
             return lines;
-        } else {
-            offset++;
         }
+        offset++;
     }
 }