Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discv5 tests currently fail #1073

Closed
Rjected opened this issue Apr 2, 2024 · 2 comments · Fixed by #1128
Closed

discv5 tests currently fail #1073

Rjected opened this issue Apr 2, 2024 · 2 comments · Fixed by #1128

Comments

@Rjected
Copy link
Contributor

Rjected commented Apr 2, 2024

Discv5 is not actually enabled in any of the clients for discv5 test suites, and there is no way for the tests to tell client.sh files that discv5 should be enabled. As a result, discv5 tests currently fail
@fjl
Copy link
Collaborator

fjl commented Apr 2, 2024

I'm aware of this. I just added the integration because the tests are implemented in go-ethereum's cmd/devp2p. We can enable them though.

@emhane emhane mentioned this issue Apr 2, 2024
Open
@fjl
Copy link
Collaborator

fjl commented Apr 3, 2024

Making this work should just be a matter of enabling discv5 on port 30303 alongside discv4.

@emhane emhane mentioned this issue Apr 15, 2024
Open
@emhane emhane mentioned this issue Jun 25, 2024
Merged
@fjl fjl closed this as completed in #1128 Jun 25, 2024
@emhane emhane mentioned this issue Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clients/reth: enable discv5 emhane/hive
2 participants
@fjl @Rjected