-
Notifications
You must be signed in to change notification settings - Fork 175
Add net_id to provide the current network id #6
Comments
https://github.com/ethcore/parity/blob/master/rpc/src/v1/impls/net.rs#L39 https://github.com/ethereum/go-ethereum/blob/3885907c7deb598ed491ca4deccc562b27b31d66/eth/api.go#L1952 Maybe we should just update the spec or rename the method? |
It looks like parity and geth are not following the spec and both return the network id instead of the network protocol version. I would suggest:
|
I guess the reason for this is that there is already If we are going to update this method I suggest it should return id and also latest fork block hash (or at least number) to distinguish possible forks (ETH vs ETC). |
I'd prefer a non breaking migration path. If we change net_version to net_id, add the new method some period of time before deprecating the old method. Otherwise, I think updating the spec is a decent immediate step. |
Making the network id accessible on the RPC will allow dapps to know on which network they are right now.
We would need that in mist to know the difference between networks and store accounts accordingly.
@bas-vk @debris @chriseth
The text was updated successfully, but these errors were encountered: