Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

current state of i18n #1735

Open
7 tasks done
luclu opened this issue Mar 14, 2017 · 4 comments
Open
7 tasks done

current state of i18n #1735

luclu opened this issue Mar 14, 2017 · 4 comments

Comments

@luclu
Copy link
Contributor

luclu commented Mar 14, 2017

Investigating, tracking and structuring issues regarding the i18n translation system.

@h3ll0fr13nd
Copy link
Contributor

For some languages, let's take nl for example as for that I was testing a bit, numeral expects 'nl-nl' and is currently receiving only 'nl'. I've tried to use nl-nl but then i18next gives issues as it seems to be expecting nl.

@luclu
Copy link
Contributor Author

luclu commented Apr 18, 2017

Thank you @h3ll0fr13nd, this has been fixed in #1783 and will make it in the next release.

@h3ll0fr13nd
Copy link
Contributor

Ok, great! Is that in another branch than the develop? I've just cloned and run the develop branch and still got nl passed to numeral instead of nl-nl:
[2017-04-18 13:37:03.186] [INFO] ipcCommunicator - Backend language set to: nl
[2017-04-18 13:37:03.236] [ERROR] (ui: mist) - numeral.js couldn't set number formating: Unknown language : nl

@luclu
Copy link
Contributor Author

luclu commented Apr 18, 2017

Ah yes, you are right! This message appears when there is no nl config upstream. It will disappear after it has been added. As this is not really an error I raised #2154. Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants