Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

[i18n] Adding language names in every i18n.json files might not be a good idea #899

Closed
ChihChengLiang opened this issue Jun 27, 2016 · 2 comments

Comments

@ChihChengLiang
Copy link
Contributor

proposal: load the language names from project-tap.i18n.

In pull request #896 , the names of the languages in change language menu are maintained in every i18n.json files as the below example shows:

"langCodes" : {
                    "de": "Deutsch",
                    "en": "English",
                    "es": "Español",
                    "fr": "Français",
                    "ja": "日本語",
                    "ko": "한국어 ",
                    "nb": "Norsk",
                    "pt": "Português",
                    "zh": "普通話",
                    "zh-TW": "國語"
                }

Suppose a new language needs to be added. Either the translation contributor needs to add that language names in every i18n.json files, or the dev team have to by somehow inform the contributor to do so and to make sure the job done right. That might be an overhead to the dev team.

Ideally, load the language names from project-tap.i18n.

@ChihChengLiang
Copy link
Contributor Author

alexvandesande's solution sounds great. We only need the language name in the en.i18n.json.

So an instruction for this is added in the Translation and i18n Guide.

@lock
Copy link

lock bot commented Apr 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Apr 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants