Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

improve test coverage and remove outdate code #78

Closed
2 tasks
alincode opened this issue Dec 7, 2018 · 2 comments
Closed
2 tasks

improve test coverage and remove outdate code #78

alincode opened this issue Dec 7, 2018 · 2 comments
Assignees
Labels
#compiler specification category
Milestone

Comments

@alincode
Copy link

alincode commented Dec 7, 2018

@todo

  • bring test coverage across all versions to 100% and re-use all tests written by the solidity team
  • run all tests in the browser inside an iframe and report to the parent window

2018-12-08 01 20 49

2018-12-08 01 21 19

@alincode alincode self-assigned this Dec 7, 2018
@alincode
Copy link
Author

2019-01-23 00 42 35

@serapath
Copy link
Contributor

serapath commented Jan 23, 2019

We somehow need to monitor https://github.com/ethereum/solc-js/commits/master to see when they change or update the compiler and update our compiler accordingly.

Maybe a release of our solc-js module should hard-code the newest available compiler version, so that the compiler on purpose ignores all compiler versions found in the version list that are newer than the version available when we made a release, so that our app doesnt break because solidity released a new incompatible version which breaks our app because they maybe changed their output format again.
what do you think?

In any case - we should find a way how we can re-run all the tests they constantly update on our compiler version. (see: https://github.com/ethereum/solc-js/tree/master/test)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
#compiler specification category
Projects
None yet
Development

No branches or pull requests

2 participants