Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout-room discussion #8 (London Infrastructure Readiness) #308

Closed
tvanepps opened this issue Apr 29, 2021 · 8 comments
Closed

Breakout-room discussion #8 (London Infrastructure Readiness) #308

tvanepps opened this issue Apr 29, 2021 · 8 comments

Comments

@tvanepps
Copy link
Collaborator

tvanepps commented Apr 29, 2021

Date and Time

Meeting Date/Time: Friday, May 7 at 1400 UTC
Meeting Duration: 60 mins
Location: Will be shared in the Infrastructure channel of the EthR&D discord channel
Recording: https://youtu.be/qce2M4ot8ls

Agenda

Next meeting - date/frequency?

Anything else? (Leave a comment)

@timbeiko
Copy link
Collaborator

One thing to go over is JSON RPC support for 1559. See this EthMagicians discussion.

@MicahZoltu
Copy link

MicahZoltu commented May 5, 2021

Geth team position on JSON-RPC naming: https://gist.github.com/karalabe/1565e0bc1be6895ad85e2a0116367ba6

@karalabe
Copy link
Member

karalabe commented May 5, 2021

Also note, the above position also has a section on the header field rename. That's not about what name we like, rather why we think any name change is bad, so please do read that part too.

@jochem-brouwer
Copy link
Member

We have had a discussion on EIP1559 on ETH R&D to change some stuff which has to do with the gasTarget/gasLimit change, see this PR ethereum/EIPs#3552, probably agenda the item to discuss/confirm these changes.

@spalladino
Copy link

I'm curious about how the existing gas price oracles (ethgasstation, gasnow, blocknative, etc) are adapting to 1559 if at all, since several clients depend on them to decide on gas price to use. Should they be included in the discussion?

@tvanepps
Copy link
Collaborator Author

tvanepps commented May 6, 2021

I'm curious about how the existing gas price oracles (ethgasstation, gasnow, blocknative, etc) are adapting to 1559 if at all, since several clients depend on them to decide on gas price to use. Should they be included in the discussion?

Yes definitely - blocknative was included in our initial outreach, but I can definitely reach out to the others.

@timbeiko
Copy link
Collaborator

timbeiko commented May 7, 2021

Here are my high-level notes from the call:

  1. We agreed to keep the gasLimit (and not target) in the block. We will reach out to miners directly to tell them to target a 2x'd gas limit on the fork block. We merged @lightclient's PR for this: ethereum/EIPs@67d0d75

  2. We agreed to have the first block with a base fee be the fork block, and not have the fork block assume the parent had a base fee set at the minimum level. We opened a PR for this: Start with default base fee on fork block EIPs#3556

  3. We'll open a PR against 1559 to add the names of the JSON RPC fields to the EIP directly for clarity. Specifically, we'll use TBA.

  4. For the rest of the JSON RPC changes, we'll spec the diff outside of EIP-1559. We can either use the eips repo (e.g. https://eips.ethereum.org/EIPS/eip-3041) or the eth1-specs repo where we're starting to move things over. Either option probably works, but we currently don't have anyone to do this. If someone wants to take this on, please ping me. Funding is available for this.

  5. I've update the Baikal spec to follow this. Note that (2) will change the commit hash for 1559, but clients already implement things this way, so they will not need to change their implementation.

  6. We didn't decide on if/when the next call would happen. We'll see where we are at on next week's AllCoreDevs.

@timbeiko
Copy link
Collaborator

timbeiko commented May 7, 2021

Recording of the call available at https://youtu.be/qce2M4ot8ls

@timbeiko timbeiko closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants