-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-1559 Gas API Call (Breakout #10) #328
Comments
One thing to discuss is how to update
|
Quick update: as per ethereum/execution-specs#201 (comment), we are likely to add a separate API for the priority fee. It would be good to use the call to discuss what value the API should provide. |
@timbeiko do we have a list of different options that it can be calculated so folks can come a bit more prepared? I'm very concerned over the implementations of the GPO so would love to help wallet devs understand what they're getting as a return value! |
Geth's implementation currently:
Auto-fill details:
The rationale's behind this thought:
Edit: Geth's gas price oracle retrieves the cheapest 3 transactions from the past X blocks, and uses the 60th percentile as the suggestion for the price. The 60th percentile ensures we're aiming for inclusion in 2-3 blocks, whereas looking at the minimums ensures we're trying to push prices downward instead of up. Edit2: X = 20 for full nodes and 2 for light clients (they need to retrieve the entire blocks to suggest a price) |
Hi! Yes some thoughts on the proposed oracle:
|
I tried to explain conceptually the mechanism, but I guess it got misunderstood somewhere along the way. Our gas price oracle internally calculates the priority fees actually paid by the transactions. For the eth_gasPrice call, we will return the estimated priority fee + 1 basefee (which will essentially be the "current" full gasPrice that we estimate pre-London). For eth_maxPriorityFeePerGas, we return the estimated priority fee. The user needs to set the |
@karalabe when you say "1 basefee", what value do you use? The base fee of the latest block, the next base fee, or something else? |
The current baseFee. |
Will the call be recorded, or will notes be taken, and made publicly available? |
I wrote a short proposal for a fee suggestion API: |
@danjm I don't think we'll have notes, but I'll upload a recording to Youtube. |
Link for the 1559 API wishlist: https://hackmd.io/@timbeiko/1559-api-wishlist |
@timbeiko Please notify me once the recording has been uploaded to YouTube. I'll get started by adding the notes. |
Recording available here: https://www.youtube.com/watch?v=SpU6WACP2cM&feature=youtu.be cc: @Santhosh1692 |
Date and Time
Date/Time: Friday, June 4 at 14:00 UTC (10:00 ET)
Duration: 60 mins
Recording: https://youtu.be/SpU6WACP2cM
Agenda
eth_maxPriorityFeePerGas
Add eth_maxPriorityFeePerGas execution-specs#201baseFeePerGas
Proposal: addeth_baseFeePerGas
method execution-specs#207⭐ Cheatsheet: 1559 for Wallets and Users ⭐
↓ Leave a comment to add anything else ↓
The text was updated successfully, but these errors were encountered: