Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus-layer Call 107 #756

Closed
djrtwo opened this issue Apr 6, 2023 · 5 comments
Closed

Consensus-layer Call 107 #756

djrtwo opened this issue Apr 6, 2023 · 5 comments
Labels

Comments

@djrtwo
Copy link
Collaborator

djrtwo commented Apr 6, 2023

Consensus-layer Call 107 Agenda

prev: call 106

Meeting Date/Time: Thursday 2023/4/20 at 14:00 UTC
Meeting Duration: 1.5 hours
Livestream

  1. Capella
    • fork retro
  2. Deneb
  3. Research, spec, etc
  4. Open Discussion/Closing Remark
@djrtwo djrtwo added the agenda label Apr 6, 2023
@timbeiko
Copy link
Collaborator

Two things that came up on the 4844 call today which we should discuss on ACDC:

  1. Potential blockers for 4844-devnet-5
  2. PR to merge getPayloadV3 & getBlobsBundleV1
  3. Blob re-orgs & newPayload(context)

@mkalinin
Copy link
Contributor

I will likely not make this call, couple of Engine API things:

Aiming to merge both PRs on Friday, last call for objections.

@mkalinin
Copy link
Contributor

Another thing to consider for Deneb:

  • Not allow slashed validator to become a proposer consensus-specs#3175 -- it started as a small change to compute_proposer_index function, but it appears that the complexity of this fix is a bit bigger as with the change to compute_proposer_index we can't use get_beacon_proposer_index inside of process_operations anymore as any slashing would change the output of this function. So, slash_validator, process_attestation and process_sync_aggregate undergoes small changes as well.

The probability of missing proposal because of a single slashing is trivial. While it increases significantly in the case of correlated slashing, for instance, 10% of slashed validators results in ~1 missed proposal per epoch on average.

@gballet
Copy link
Member

gballet commented Apr 20, 2023

If there's time, I would like to have a <10 minute conversation about the Verge, namely for having a number field in the JSON of the execution payload.

Context: In the spec, the SuffixDiff object has a Suffix byte. It seems that the agreement for the API so far, is to always use hex strings for any number. Given how often this field is going to be repeated, however, it would be wasteful to use a hex string here.

Discussion point: We would like to use a regular JSON number for this field, instead of a hex string.

@mkalinin
Copy link
Contributor

Discussion point: We would like to use a regular JSON number for this field, instead of a hex string.

We can use JSON integer type for this field, implementation complexity should be trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants