Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit c14d7f7

Browse files
committedDec 12, 2018
tests: add more tests to INCORRECT_UPSTREAM_TESTS.
One is existing `RevertInCreateInInit`, but now for Constantinople, not just Byzantium. The other is `RevertInCreateInInitCreate2`, which contains the same "synthhetic" state which can't be arrived at by regular means in the EVM. It's likely a copy-paste atavism.
1 parent 130ebf6 commit c14d7f7

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed
 

‎tests/json-fixtures/test_blockchain.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,11 @@
4545
# The result is in conflict with the yellow-paper:
4646
# * https://github.com/ethereum/py-evm/pull/1224#issuecomment-418800369
4747
('GeneralStateTests/stRevertTest/RevertInCreateInInit_d0g0v0.json', 'RevertInCreateInInit_d0g0v0_Byzantium'), # noqa: E501
48+
('GeneralStateTests/stRevertTest/RevertInCreateInInit_d0g0v0.json', 'RevertInCreateInInit_d0g0v0_Constantinople'), # noqa: E501
49+
# The CREATE2 variant seems to have been derived from the one above - it, too,
50+
# has a "synthetic" state, on which py-evm flips.
51+
# * https://github.com/ethereum/py-evm/pull/1181#issuecomment-446330609
52+
('GeneralStateTests/stCreate2/RevertInCreateInInitCreate2_d0g0v0.json', 'RevertInCreateInInitCreate2_d0g0v0_Constantinople'), # noqa: E501
4853
}
4954

5055

‎tests/json-fixtures/test_state.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,11 @@ def expand_fixtures_forks(all_fixtures):
146146
# The result is in conflict with the yellow-paper:
147147
# * https://github.com/ethereum/py-evm/pull/1224#issuecomment-418800369
148148
('stRevertTest/RevertInCreateInInit.json', 'RevertInCreateInInit', 'Byzantium', 0),
149+
('stRevertTest/RevertInCreateInInit.json', 'RevertInCreateInInit', 'Constantinople', 0),
150+
# The CREATE2 variant seems to have been derived from the one above - it, too,
151+
# has a "synthetic" state, on which py-evm flips.
152+
# * https://github.com/ethereum/py-evm/pull/1181#issuecomment-446330609
153+
('stCreate2/RevertInCreateInInitCreate2.json', 'RevertInCreateInInitCreate2', 'Constantinople', 0), # noqa: E501
149154
}
150155

151156

0 commit comments

Comments
 (0)
Please sign in to comment.