Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for rewards #1315

Closed
cburgdorf opened this issue Sep 22, 2018 · 3 comments
Closed

Add more tests for rewards #1315

cburgdorf opened this issue Sep 22, 2018 · 3 comments

Comments

@cburgdorf
Copy link
Contributor

What is wrong?

We recently added unit tests (additional to the existing state tests) that cover the rewards that are paid to the miners.

We should expand the following cases (citing from)

  • calculating uncle/nephew reward when the uncle is on a different VM (like: uncle in frontier at 0, nephew in constantinople at 1)
  • uncles that are 2 -> 8 layers back
  • validating that uncles > 8 back are invalid

(I'm saying the last two without having reviewed the uncles section of the YP recently, so probably have some detail wrong)

How can it be fixed

Add test here

@pipermerriam
Copy link
Member

pipermerriam commented Sep 25, 2018

Tests should be reasonably easy to write using the new chain builder tools and/or the fixture builder.

Fixture-builder would be ideal as we could potentially contribute those back upstream, but it's probably best to just start with chain-builder.

@Bhargavasomu
Copy link
Contributor

I'm taking this up.

@Bhargavasomu
Copy link
Contributor

This can be closed with #1685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants