-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solc 0.5.x compatibility, ability to change compilers as needed #65
Conversation
Didn't see this one when I made mine. Fixes everything on my machine. |
This PR is also failing the travis checks, and like you I'm not familiar with it's use. I think the issue is because the tests are written assuming that solc is installed to /usr/bin but with how I've modified it, solc is now installed elsewhere. Also this PR will need some more work to support windows users. As suggested in the community guidelines, this is more meant to open a discussion as to whether this approach is one that's worth working on further. |
Yeah it looks like @pipermerriam and co are pretty busy over at web3.py getting it up to speed with Sol 0.5.x, hopefully the wrapper fixes are fairly easy and we can bring this up to spec soon as well. As far as I know, the clone-bin issue was the only breaking change for the wrapper. |
Any updates on this? |
It's very likely that |
@pipermerriam Thanks for the update. Do you see any alternative to |
Not that we plan to build/maintain but it should be quite trivial to fork this repository and maintain/update it yourself if it is an important part of your stack. |
@pipermerriam thanks for letting us know, and for your work on this project to date. I rely on Update - my forked repo is now available on pypi:
|
What was wrong?
Over the next few months, I'd imagine may of us will be working with contracts on both 0.4.x and 0.5.x simultaneously. To that end, it would be useful to be able to easily switch compiler versions.
How was it fixed?
wrapper.py
- line 87, added a check for version 0.5.x to remove the clone-bin argument if neededinstall.py
- can now install versions 0.5.0 and 0.5.1, and each version of solc is installed intopy-solc/bin/solc/
main.set_solc_version
- modifies which compiler py-solc is actively using, and installs if necessarymain.get_installed_solc_versions
- to see which versions of solc have been installed__init__.py
so that on the first import it installs solc v0.5.1fixes #63
fixes #64
Cute Animal Picture