Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming and converntion for ExpressionContext #66

Open
pipermerriam opened this issue Feb 6, 2019 · 0 comments
Open

Better naming and converntion for ExpressionContext #66

pipermerriam opened this issue Feb 6, 2019 · 0 comments

Comments

@pipermerriam
Copy link
Member

#55 introduced ExpressionContext which isolates the mutable components of expression validation.

This name is still not sitting right with me. I don't like the name collision with the Context object. I think renaming it to ExpressionValidator would be acceptable, but then that leaves the question about what should be done with the various APIs that are on the Context object which need to be accessed during expression validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant