-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support async read callbacks. #140
Comments
This is currently not fixable due to the use of emscripten. They offer some ways to work around the problem, but as far as I know, it does not work properly yet. |
Any progress on this? |
Closing for inactivity. |
Reopen please, I'm implementing Deno bindings for solc and there's no way for supporting URL imports because |
Hi @talentlessguy ! ps: Nice work with the solidity bindings for deno! |
@matheusaaguiar as far as I saw on Google, emscripten-core/emscripten#14728 Maybe solc binaries could come with async support without making a separate sync binary, just ship async by default p.s. thank you! |
@talentlessguy It seems that could be the case. Nevertheless, we still would need to do some work, as, for example, maintaining compatibility in |
Ideally using modern techniques (meaning promises). At the moment, the
readCallback
is expected to return a result synchronously. This is impossible to do in the browser and against best practices in node. This function should instead be expected to return aPromise<string>
and reject the promise with an Error on failure.The text was updated successfully, but these errors were encountered: