Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Expose all settings present in standard-json to the cli #10274

Closed
axic opened this issue Nov 12, 2020 · 7 comments
Closed

[CLI] Expose all settings present in standard-json to the cli #10274

axic opened this issue Nov 12, 2020 · 7 comments
Labels
medium effort Default level of effort medium impact Default level of impact should have We like the idea but it’s not important enough to be a part of the roadmap.

Comments

@axic
Copy link
Member

axic commented Nov 12, 2020

(This issue is splitting up #8847.)

Some options available to the standard-json format do not seem to be available as CLI flags. I'm missing in particular source mappings for yul which was introduced only for the json options in #8378. It would be nice if feature parity between CLI flags and json opts was pursued as a general rule.

@cameel
Copy link
Member

cameel commented Sep 9, 2021

CLI has no equivalent for evm.bytecode.linkReferences and evm.deployedBytecode.immutableReferences outputs from Standard JSON.

@cameel
Copy link
Member

cameel commented Oct 15, 2021

Another thing are all the outputs available in assembly mode in Standard JSON. #12074 allows selecting outputs in assembly mode but does not add anything beyond what compiler was already printing.

@NunoFilipeSantos NunoFilipeSantos added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 25, 2022
@cameel cameel added good first issue candidate Could be a "good first issue" but something is blocking it or it has open questions. and removed good first issue labels Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

Hi everyone! This issue has been closed due to inactivity.
If you think this issue is still relevant in the latest Solidity version and you have something to contribute, feel free to reopen.
However, unless the issue is a concrete proposal that can be implemented, we recommend starting a language discussion on the forum instead.

@github-actions github-actions bot added the closed due inactivity The issue/PR was automatically closed due to inactivity. label Feb 5, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2023
@cameel
Copy link
Member

cameel commented Feb 6, 2023

I think this is something we still want to (or at least should) do. Reopening.

@cameel cameel reopened this Feb 6, 2023
@cameel cameel added medium effort Default level of effort medium impact Default level of impact should have We like the idea but it’s not important enough to be a part of the roadmap. and removed closed due inactivity The issue/PR was automatically closed due to inactivity. stale The issue/PR was marked as stale because it has been open for too long. easy difficulty good first issue candidate Could be a "good first issue" but something is blocking it or it has open questions. labels Feb 6, 2023
@ekpyron
Copy link
Member

ekpyron commented Feb 6, 2023

This is an obvious part of rewriting CLI backed by standard-json. Do we really need a separate issue for this? We won't do it before that and without that - and with that, we can do it right away...

@cameel
Copy link
Member

cameel commented Feb 6, 2023

I'm not sure it's an obvious part. You could very well rewrite it keeping the features it has currently without adding parity.

@ekpyron
Copy link
Member

ekpyron commented Feb 7, 2023

We'll achieve parity by just allowing the CLI to generically amend the standard-json it generates while deprecating. It's part of the rewrite, I'm closing this :-).

@ekpyron ekpyron closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium effort Default level of effort medium impact Default level of impact should have We like the idea but it’s not important enough to be a part of the roadmap.
Projects
None yet
Development

No branches or pull requests

4 participants