Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark differ extensions #12869

Closed
4 tasks
cameel opened this issue Mar 28, 2022 · 2 comments
Closed
4 tasks

Benchmark differ extensions #12869

cameel opened this issue Mar 28, 2022 · 2 comments
Assignees
Labels
closed due inactivity The issue/PR was automatically closed due to inactivity. stale The issue/PR was marked as stale because it has been open for too long. testing 🔨

Comments

@cameel
Copy link
Member

cameel commented Mar 28, 2022

Related to #12522.

There are a few tiny features that would be nice to have in benchmark differ/downloader that I haven't implemented in #12804 and #12818. I'm creating this issue to track what I'm still going to implement:

  • Option to include a column with absolute values next to relative ones in the table.
  • Script for filtering projects/presets. This would allow for example to filter a benchmark summary into two JSONs - one for IR and one for legacy - and diff them to see how the codegens compare.
  • Option not to show zero values (requested in Benchmark differ #12804 (comment))
    • Alternatively: hiding "unimportant" values (zeros and rounded to zero, missing on one side, different version, type error, etc.)
  • Option not to skip values when versions differ (Benchmark differ #12804 (comment))
@github-actions
Copy link

This issue has been marked as stale due to inactivity for the last 90 days.
It will be automatically closed in 7 days.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Mar 25, 2023
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

Hi everyone! This issue has been automatically closed due to inactivity.
If you think this issue is still relevant in the latest Solidity version and you have something to contribute, feel free to reopen.
However, unless the issue is a concrete proposal that can be implemented, we recommend starting a language discussion on the forum instead.

@github-actions github-actions bot added the closed due inactivity The issue/PR was automatically closed due to inactivity. label Apr 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed due inactivity The issue/PR was automatically closed due to inactivity. stale The issue/PR was marked as stale because it has been open for too long. testing 🔨
Projects
None yet
Development

No branches or pull requests

2 participants