Rewrite FunctionCallGraph tests as soltest test suite

[cameel]

FunctionCallGraph is currently covered with boost tests. These tests are generally harder to maintain and update than our soltest-style tests.

We should define a custom test case class for them and put expectations in annotations. See StackLayoutGeneratorTest and test/libyul/yulStackLayout/ for an example of such a custom test suite and test cases based on it.

Example

We should be able to replace the following test case:

solidity/test/libsolidity/analysis/FunctionCallGraph.cpp

Lines 253 to 292 in a3de6cd

	BOOST_AUTO_TEST_CASE(only_definitions)
	{
	unique_ptr<CompilerStack> compilerStack = parseAndAnalyzeContracts(R"(
	function free() {}
	library L {
	function ext() external {}
	function pub() public {}
	function inr() internal {}
	function prv() private {}
	}
	contract C {
	function ext() external {}
	function pub() public {}
	function inr() internal {}
	function prv() private {}
	}
	)"s);
	tuple<CallGraphMap, CallGraphMap> graphs = collectGraphs(*compilerStack);
	map<string, EdgeNames> expectedCreationEdges = {
	{"C", {}},
	{"L", {}},
	};
	map<string, EdgeNames> expectedDeployedEdges = {
	{"C", {
	{"Entry", "function C.ext()"},
	{"Entry", "function C.pub()"},
	}},
	{"L", {
	{"Entry", "function L.ext()"},
	{"Entry", "function L.pub()"},
	}},
	};
	checkCallGraphExpectations(get<0>(graphs), expectedCreationEdges);
	checkCallGraphExpectations(get<1>(graphs), expectedDeployedEdges);
	}

with a .sol file that looks like this:

function free() {}

library L {
    function ext() external {}
    function pub() public {}
    function inr() internal {}
    function prv() private {}
}

contract C {
    function ext() external {}
    function pub() public {}
    function inr() internal {}
    function prv() private {}
}
// ----
// CREATION
//     contract C
//     library L
// DEPLOYED
//     contract C
//         Entry -> function C.ext()
//         Entry -> function C.pub()
//     library L
//         Entry -> function L.ext()
//         Entry -> function L.pub()

[0xGeorgii]

Hi @cameel I'm new to Solidity but want to dig deeper into it. May I elaborate on this issue and provide an improvement? It takes some time and I will ask questions. Hope it won't be too bothering.

[matheusaaguiar]

Hi @GeorgePlotnikov , maybe this issue is not really a good first issue for someone starting out, because it could demand understanding of how other test classes are implemented. I am not sure how long you are digging into solidity or how much time you are dedicating to it. So in order to give you more options, I'd like to suggest some other good first issues:

• Pretty print expected json output of command line tests
• Errors reported for modifier overloading should outright say that overloading is not allowed
  I just wanted to give you more options and remark that this is a medium size task, so if you are new, you might want a smaller one.

[0xGeorgii]

hi @matheusaaguiar thanks for clarifying. Let me consider these two before. If this one will be still orphaned I grab it.

[github-actions]

This issue has been marked as stale due to inactivity for the last 90 days.
It will be automatically closed in 7 days.

[github-actions]

Hi everyone! This issue has been automatically closed due to inactivity.
If you think this issue is still relevant in the latest Solidity version and you have something to contribute, feel free to reopen.
However, unless the issue is a concrete proposal that can be implemented, we recommend starting a language discussion on the forum instead.