Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ir output is not included in Standard JSON when requesting all outputs via * #14363

Open
cameel opened this issue Jun 26, 2023 · 0 comments
Open
Labels
bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it.

Comments

@cameel
Copy link
Member

cameel commented Jun 26, 2023

Currently, when you request all outputs in Standard JSON with "outputSelection": {"*": {"*": ["*"]}, the ir and irOptimized outputs are not included.

This seems to be because the IR generation used to be considered experimental:

else if (selectedArtifact == "*")
{
// "ir", "irOptimized" can only be matched by "*" if activated.
if (experimental.count(_artifact) == 0 || _wildcardMatchesExperimental)
return true;
}

In 0.8.13 it became a stable feature, and I think that these outputs should have been added to * back then.

@cameel cameel added bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it. labels Jun 26, 2023
@cameel cameel changed the title IR output is not included in Standard JSON output when requesting all outputs via * ir output is not included in Standard JSON when requesting all outputs via * Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant