Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test against breaking storage layout changes #4049

Closed
chriseth opened this issue May 2, 2018 · 1 comment
Closed

Add test against breaking storage layout changes #4049

chriseth opened this issue May 2, 2018 · 1 comment
Labels
closed due inactivity The issue/PR was automatically closed due to inactivity. stale The issue/PR was marked as stale because it has been open for too long. testing 🔨

Comments

@chriseth
Copy link
Contributor

chriseth commented May 2, 2018

From #4017 - we should add tests that would detect storage layout changes.

Tests could set some storage values and then use inline assembly to read at fixed points in storage (where we expect the changes to happen).

Tests should include:

  • (multiple) inheritance
  • constants
  • mappings
  • arrays
  • structs
  • packed data
@chriseth chriseth mentioned this issue May 2, 2018
Closed
@NunoFilipeSantos NunoFilipeSantos added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 25, 2022
@github-actions
Copy link

Hi everyone! This issue has been closed due to inactivity.
If you think this issue is still relevant in the latest Solidity version and you have something to contribute, feel free to reopen.
However, unless the issue is a concrete proposal that can be implemented, we recommend starting a language discussion on the forum instead.

@github-actions github-actions bot added the closed due inactivity The issue/PR was automatically closed due to inactivity. label Jan 27, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed due inactivity The issue/PR was automatically closed due to inactivity. stale The issue/PR was marked as stale because it has been open for too long. testing 🔨
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@axic @NunoFilipeSantos @chriseth